wx.py.dispatcher conceptual bug

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

wx.py.dispatcher conceptual bug

sebastian lópez
Hi 

I was testing my app by using wx.py.dispatcher and I found it doesn't dispatch events, because of a conceptual error related to the used words any and anonymous

wx.py.dispatcher lines 39 to 149

the sender could be "Anonymous" but not "Any"
the signal coud be "Any" but not "Anonymous"

I appended the corrected file.

wx.__version__ 4.0.0a2.dev2973+5ff6be7

--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.

dispatcher.py (9K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: wx.py.dispatcher conceptual bug

Robin Dunn
sebastian lópez wrote:

> Hi
>
> I was testing my app by using wx.py.dispatcher and I found it doesn't
> dispatch events, because of a conceptual error related to the used
> words any and anonymous
>
> wx.py.dispatcher lines 39 to 149
>
> the sender could be "Anonymous" but not "Any"
> the signal coud be "Any" but not "Anonymous"
>
> I appended the corrected file.
>
> wx.__version__ 4.0.0a2.dev2973+5ff6be7
>

Please submit this change as a PR to
https://github.com/wxWidgets/Phoenix so it is easier to review, and
discuss if needed.  See these links if you are not familiar with the Git
and PR workflows:

    https://help.github.com/articles/fork-a-repo/
    https://help.github.com/articles/about-pull-requests/


--
Robin Dunn
Software Craftsman
http://wxPython.org

--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: wx.py.dispatcher conceptual bug

sebastian lópez
It's Done !



El lunes, 8 de mayo de 2017, 17:09:32 (UTC-5), Robin Dunn escribió:
sebastian lópez wrote:

> Hi
>
> I was testing my app by using wx.py.dispatcher and I found it doesn't
> dispatch events, because of a conceptual error related to the used
> words any and anonymous
>
> wx.py.dispatcher lines 39 to 149
>
> the sender could be "Anonymous" but not "Any"
> the signal coud be "Any" but not "Anonymous"
>
> I appended the corrected file.
>
> wx.__version__ 4.0.0a2.dev2973+5ff6be7
>

Please submit this change as a PR to
<a href="https://github.com/wxWidgets/Phoenix" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FwxWidgets%2FPhoenix\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHIj2jimA5oEqkP5PprVXP7-XSHJA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FwxWidgets%2FPhoenix\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHIj2jimA5oEqkP5PprVXP7-XSHJA&#39;;return true;">https://github.com/wxWidgets/Phoenix so it is easier to review, and
discuss if needed.  See these links if you are not familiar with the Git
and PR workflows:

    <a href="https://help.github.com/articles/fork-a-repo/" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Farticles%2Ffork-a-repo%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFVKtmFS3o9NdEAt5_hNqPfo1XYLg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Farticles%2Ffork-a-repo%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFVKtmFS3o9NdEAt5_hNqPfo1XYLg&#39;;return true;">https://help.github.com/articles/fork-a-repo/
    <a href="https://help.github.com/articles/about-pull-requests/" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Farticles%2Fabout-pull-requests%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNG8zMDci9Pb4XBTgBdgGAP_BNP_6w&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Farticles%2Fabout-pull-requests%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNG8zMDci9Pb4XBTgBdgGAP_BNP_6w&#39;;return true;">https://help.github.com/articles/about-pull-requests/


--
Robin Dunn
Software Craftsman
<a href="http://wxPython.org" target="_blank" rel="nofollow" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2FwxPython.org\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHG9kM-NEpJfIvl_lWJvA23SuLjOA&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2FwxPython.org\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHG9kM-NEpJfIvl_lWJvA23SuLjOA&#39;;return true;">http://wxPython.org

--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Loading...